search

RoboCup-SSL / ssl-vision

Shared Vision System For The RoboCup Small Size League
GNU General Public License v3.0
90 stars 111 forks source link

Hotfix/integer division #150

Closed rolfvdhulst closed 4 years ago

rolfvdhulst commented 5 years ago

Fixes an integer division bug which makes timings only accurate up to 1 second. Has been tested with the actual camera´s to verify the fix.

fixes #149

g3force commented 5 years ago

You've replaced the Makefile by some large generated one ;) And there are some unrelated formatting changes btw. Wouldn't it be easier to just make the single change, instead of reverting all the unrelated changes? ;)

rolfvdhulst commented 4 years ago

I made a new pr from my personal fork. We are running only our fork with some edits (of which I don't know the exact nature) on our vision computers, so I had no easy way to revert changes whilst also testing with the real camera's. I made a PR with the isolated changes from my own fork now (see #157 ), which should just be fine in itself.

g3force commented 4 years ago

Ok. Would still be interesting to compare your diffs with the master and see, if there are other fixes that are relevant for other users.

rolfvdhulst commented 4 years ago

As far as I am aware there is nothing, we're a bit behind master and have some hooks for our own custom vision system that uses ArUco tags, but that is not performing well enough at the moment to be relevant for others (we run into similar problems as mentioned in the april tags pr, mostly camera distortion and motion blur issues with certain camera's, and simply performance issues with some computations being too slow).