Change Spelling of SSL_FieldCicularArc to SSL_FieldCircularArc in messages_robocup_ssl_geometry.proto

RoboCup-SSL / ssl-vision

Shared Vision System For The RoboCup Small Size League

GNU General Public License v3.0

90 stars 110 forks source link

Change Spelling of SSL_FieldCicularArc to SSL_FieldCircularArc in messages_robocup_ssl_geometry.proto #170

Closed jonathanlew closed 4 years ago

jonathanlew commented 4 years ago

We found that SSL_FieldCicularArc in messages_robocup_ssl_geometry.proto was missing an "r". The correct spelling is SSL_FieldCircularArc. We realize that fixing this can cause some backwards compatibility problems, but we just wanted to make the codeowners aware of the issue

g3force commented 4 years ago

Good catch. I also came across it once. It it wrong for several years already.

Anyhow, I've created a fix. Regarding the compatibility: The name of messages and fields is not transmitted, so unless someone copies the updated .proto file into their software, this does not effect compatibility. And the difference should be detected by the compiler anyway.