search

RoboCup-SSL / ssl-vision

Shared Vision System For The RoboCup Small Size League
GNU General Public License v3.0
88 stars 109 forks source link

qt4 support / CircleCI #196

Closed emielsteerneman closed 1 year ago

emielsteerneman commented 1 year ago

I was wondering if qt4 support is still needed. I assume most SSL-Vision users run Ubuntu. qt4 has been removed from Ubuntu from 20.04 onward. qt5 seems to work well. Additionally, the qt4 CircleCI check is, for me personally, hindering development https://app.circleci.com/pipelines/github/RoboCup-SSL/ssl-vision/281/workflows/0739e6b7-a421-4906-9c75-7358ed6cb9c6/jobs/950

g3force commented 1 year ago

Yeah, I agree. Should be feasible for people to upgrade to at least Ubuntu 20.04, to run ssl-vision.

Could you create a PR with the removal? The flags in CMake and the CircleCI Job should be removed then.

emielsteerneman commented 1 year ago

Created the PR here https://github.com/RoboCup-SSL/ssl-vision/pull/197