search

RoboCup-SSL / ssl-vision

Shared Vision System For The RoboCup Small Size League
GNU General Public License v3.0
90 stars 110 forks source link

build fails with -DUSE_DC1394=false when libdc1394 is not installed #198

Closed kenshin33 closed 1 year ago

kenshin33 commented 1 year ago

compilation fails to finish complaining a bout a missing header provided by libdc1394

this line should be guarded by either DC1394 or NO_DC1394_CONVERSIONS as it was done in https://github.com/RoboCup-SSL/ssl-vision/commit/979dc066892153df1e3ab6f46ea3177873352721

g3force commented 1 year ago

Interesting. Looks like nobody ever tested this before.

Would you mind creating a PR with your suggested fix?

We could also remove the package from the installation script and only mention the required package in the Readme.

kenshin33 commented 1 year ago

sure thing . But for the record, I have no idea what this project does or how it works. I just stumbled on this issue while helping someone build it!

kenshin33 commented 1 year ago

fixed in https://github.com/RoboCup-SSL/ssl-vision/pull/199