RoboCupAtHome / RuleBook

Rulebook for RoboCup @Home 2024
https://robocupathome.github.io/RuleBook/
Other
149 stars 61 forks source link

Q: Grammar Generator Permanence? #332

Closed MeeraWakim closed 7 years ago

MeeraWakim commented 7 years ago

For the Speech and Person Recognition task in Stage 1, the grammar generator outputs some grammatically incorrect/unconventional sentences.

Will the people reading them in the competition alter these sentences to make them more correct/conventional, or will they be required to read them verbatim?

Or will the grammar generator code change in any way right before the competition?

LoyVanBeek commented 7 years ago

The referees will apply common sense when using the generator, as it can indeed make up nonsensical sentences.

The code will change to accommodate the object set present at the venue.

justinhart commented 7 years ago

So, to clarify, does this mean that we should parse what is output by the generator as English sentences, expecting the referees to correct the syntax when they read them? Might they change the syntax of relatively awkward utterances? For instance "Where is located the {placement}?" is an awkward sentence. Can we expect that a judge might say, "Where is the ${placement} located?"

LoyVanBeek commented 7 years ago

That example is indeed a bit awkward but a valid English sentence.

@kyordhel, care to chime in?

kyordhel commented 7 years ago

This is an issue for the generator, I think.

Indeed; I must admit that not all the generated sentences obey (American) english common sense, which by the way is not compliant with Oxford grammar, to name one. Nonetheless, from the perspective of the rules, this should represent no problem for robots for the volunteers rarely repeat verbatim the given instructions, and that supposing they are grammatically correct (which often is not the case).

@justinhart I assume you are native English speaker. Could you please help us with a PR including some grammar corrections in the generator?

justinhart commented 7 years ago

We're still in the heat of preparing our team for RoboCup@Home, but when there's time, I'd be happy to address this.

kyordhel commented 6 years ago

@justinhart, can we address this now? Hope you have time.

justinhart commented 6 years ago

Yep. I'll take a look.