Fixed so it is possible to use sails-disk db for local testing

RoboCupDev / tournamenter

Tournament Manager

Apache License 2.0

2 stars 1 forks source link

Fixed so it is possible to use sails-disk db for local testing #25

Closed TechnoX closed 9 years ago

TechnoX commented 9 years ago

Changed datatype of id in Team.js model from string to integer, see issue #23 .

mrshu commented 9 years ago

@TechnoX looks good to me, thanks a lot for doing this!

For some reason we are not passing the tests, I'll look into that.

mrshu commented 9 years ago

@ivanseidel I am very sorry but this is way too deep for me. Can you please help us?

ivanseidel commented 9 years ago

It requires string datatype. It might not pass the tests, but will work...

What was wrong, before, is that it was set to string, but without auto_increment. Setting it as integer will fail tests because mongo-db uses strings as Ids, and that would only work with local db or Mysql...

mrshu commented 9 years ago

Thanks @ivanseidel, I'm merging this then. I am not sure if the tests make sense then...

ivanseidel commented 9 years ago

Just checking things again to make sure. Maybe something is really wrong...

mrshu commented 9 years ago

Thanks a lot @ivanseidel!