Create table manager

[ivanseidel]

Features:

• Add/Delete Tables in same page
• In-place edition of Table name.
• Add/remove teams from table.
• Options to sort/calculate final score/columns qtd.
• Rename table headers

To add:

• Import ALL teams
• Simple set score view

[mrshu]

A few other comments:

• When I add a team to the table, sails says

error: Server Error (500)
error: { ValidationError: { teamId: [ [Object] ] } }

What do we do about that?

• It is apparently only possible to change the 'Score' part of the column name. I realize that it is by design so I would like to clarify that these are are supposed to be the names of rounds in Rescue for instance. Is that correct? If so, where should be the partial results stored (like score for the first room, the victim, etc.)?
• We really need tests. If we do not have a solid test coverage then we can only hope that we tested everything.
• There are some missing gifs: assets/img/loading.gif, assets/select2/select2-spinner.gif and a png assets/img/clear.png. Is it intentional?

Other than that it's great!

[ivanseidel]

• When I add a team to the table, sails says [...] Can you be more specific? When adding a score row, or setting a team in a score row?
• It is apparently only possible to change the 'Score' part of the column name. I realize that [...] That is correct. You only change the 'initial' part, but the end is always concatenated with N where N is the position. Notice that it will be inserted in the scores array, inside the Scores Model. The structure of scores is as is follows:

scores: {
  1: {value: <ComputedValueOfRound>, data:{<ExtraData, such as victims... stored as object>}},
  3: {value: <ComputedValueOfRound>, data:{<ExtraData, such as victims... stored as object>}},
  4: {value: <ComputedValueOfRound>, data:{<ExtraData, such as victims... stored as object>}},
  [...]
}

• We really need tests. If we do not have a solid test coverage then we can only hope that we tested everything. I don't know how to do that... Can you help me?
• There are some missing gifs: assets/img/loading.gif[...] It's not intentional... I think that are some files missing from jQuery and select2, that aren't necessary. If we add them problem is solved... better than hacking on the library

[ivanseidel]

Fixed that @mrshu ! It's a problem with the Model... The last commit fixed that (I'm used to have keys as integers, not hashed strings like in MongoDB...)

[mrshu]

Can you be more specific? When adding a score row, or setting a team in a score row?

Sorry, you obviously already figured that out -- I can no longer reproduce it. Thanks!

Regarding scores, thanks, I understand it better now.

I'll put some tests together although it's a bit strange that sails has no documentation on it -- in my opinion tests are the only thing that keeps rapid development sane.

The assets (images) should be no longer a problem, I've opened a new pull request for them (see #8).

Regarding this pull request, there is just one think from my side: those functions in the model (like generateTableHeaders). Once we decide what is best here, I think we can safely merge this in.

[ivanseidel]

The problem occurred when I changed to mongo, that uses Id's as strings not integers, and the Model was using integer...

Think in Sails as just an easy way to get RESTfull API running, with MVC, however, there are full-stack frameworks, but I don't like it very much.... Whatever feature we want to add to it, search as a node.js module, not a Sails one... You will find more useful information I think

the use of 'this' can only be done, because Sails models run methods injecting the global variable as being the same model, allowing us to use 'this' instead of a parameter. Putting it outside the model is only to serve the purpose of organisation. We can change it's place to inside the model, no problem.

[mrshu]

Ok then, feel free to merge this in.