search

RoboDurden / Hoverboard-Firmware-Hack-Gen2.x

with different defines_2-x.h for different board layouts :-) Compiles with Keil version 6
GNU General Public License v3.0
73 stars 24 forks source link

Document HoverSetupEsp32 method for better clarity #47

Closed andyshmandy closed 6 months ago

andyshmandy commented 6 months ago

-Changed method variable names to hopefully avoid confusing GPIO Port number with ESP32 pin numbers. -Added comments to help clarify confusion.

RoboDurden commented 6 months ago

I don't like this gpio_port_RX instead if pin.

For hoverboard MCU there is a pin 5 and port A or B or C.. which adds to PB6 or PA6.

On Arduino side it is only a pin number gpio_6

Yes. Others also had problems with the pin number of the footprint and the gpio number :-(

So maybe drop all pin and port and only define gpio_6

If you agree, please update your fork. I think that will also update this pull request

andyshmandy commented 6 months ago

I removed the references to GPIO 'port'. I agree that this is better.