Users without an uploaded resume can see resume links

[georgeburdell]

Error in Apiary

Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException in GET /api/v1/users/13/resume The file "/var/www/apiary/production/storage/app/resumes/username_redacted.pdf" does not exist

View on Bugsnag

Stacktrace

app/Http/Controllers/ResumeController.php:29 - App\Http\Controllers\ResumeController::show
app/Http/Middleware/PermissionMiddleware.php:34 - App\Http\Middleware\PermissionMiddleware::handle
app/Http/Middleware/CASAuthenticate.php:143 - App\Http\Middleware\CASAuthenticate::handle
app/Http/Middleware/APITokenAuthenticate.php:38 - App\Http\Middleware\APITokenAuthenticate::handle

View full stacktrace

Created by RoboJackets Admin via Bugsnag

[JoshOldenburg]

Additionally, ResumeController::show should return a 404, not a 500, when the specified user does not have a resume.

[JoshOldenburg]

I can't replicate the link being visible.

[JoshOldenburg]

The user says it happened after they uploaded a document that's multiple pages long.