search

RoboJackets / robocup-software

Georgia Tech RoboJackets Software for the RoboCup Small Size League
Apache License 2.0
179 stars 186 forks source link

[TODO] Make SSL ball stuff a `RosConverter` #1588

Closed HussainGynai closed 3 years ago

HussainGynai commented 4 years ago

Pull request: N/A

Link to TODO, or file number/line: https://github.com/RoboJackets/robocup-software/blob/ros2/rj_utils/include/rj_utils/conversions.hpp

DetectionBallMsg - @joshkirsh720 DetectionRobotMsg - @adithya-gv

kylestach commented 3 years ago

Here is an example of a RosConverter: https://github.com/RoboJackets/robocup-software/blob/1aa4cee694700dd91c4fbb1eb343c8dc772a50fe/rj_geometry/include/rj_geometry/geometry_conversions.hpp#L24-L42

You will need to make a new overload of RosConverter for the SSL_DetectionBall or SSL_DetectionRobot classes (associating them with DetectionBallMsg and DetectionRobotMsg respectively).

Make sure it goes in the rj_convert namespace, or it won't be found!

kylestach commented 3 years ago

Closed by #1597 and #1612.