RoboJackets / robocup-software

Georgia Tech RoboJackets Software for the RoboCup Small Size League
Apache License 2.0
183 stars 187 forks source link

Stuff gets messed up when you switch teams after launch #30

Closed justbuchanan closed 10 years ago

justbuchanan commented 10 years ago

It seemed like there were multiple copies of the robots on the field. Also, the coordinate system was backwards.

xxia34 commented 10 years ago

Removed option to use blue as team

ehuang3 commented 10 years ago

You may need to run as blue team at comp ...

justbuchanan commented 10 years ago

I think she just meant she removed the option to switch teams after soccer is started (you can now only choose the team at startup as a command-line option), right @xxia34?

Also, could you link the commit to this issue so we can revisit it at some point? Thanks!

ehuang3 commented 10 years ago

My bigger concern is that the solution doesn't match the problem.

It's like say, you notice a bear in the house every time you enter through the front door. Locking the front door and using the back doesn't remove the bear.

justbuchanan commented 10 years ago

I agree that it would be nice to switch teams from within the gui, but it's a non-essential feature and will probably take too long to fix at the moment. For now, a good way to prevent issues is to just disable switching mid-run.

It may not be too hard of a fix to get it working, but I noticed robots getting duplicated as well as coordinate-system flippage, which I'd rather not mess with right now since our before-comp todo list is already pretty big.

xxia34 commented 10 years ago

Is the option to change to blue in "Field" the one i should remove from the UI?

justbuchanan commented 10 years ago

The problem was that if you switch teams from yellow -> blue OR blue -> yellow while soccer is running, we run into issues. We want the gui to show which team you are currently, but not let you change it. We can still select the team at startup by passing the '-y' or '-b' flag when we run ./soccer, we just won't be able to change it mid-run.

xxia34 commented 10 years ago

Okay. Should I also remove the kick off blue button? because that doesn't seem to be working well either.

justbuchanan commented 10 years ago

Keep in mind, as @ehuang3 mentioned, that at comp we need to be able to play as either team. Are you talking about the kick off blue button in the referee tab? What's not working about it?

xxia34 commented 10 years ago

The Blue robots does not move even after clicking kick off, they just draw paths

justbuchanan commented 10 years ago

That's probably a separate issue besides the button / referee. What branch are you on?

Either way, don't remove or disable the button. Go ahead and make a new issue for it if you can't figure out what the problem is.

xxia34 commented 10 years ago

I reset my commits. but i did make a branch named blueTeam.