RoboJackets / robocup-software

Georgia Tech RoboJackets Software for the RoboCup Small Size League
Apache License 2.0
178 stars 187 forks source link

Pull field dimensions from vision packet #334

Closed barulicm closed 8 years ago

barulicm commented 9 years ago

SSL-Vision now includes field geometry in vision packets. We should at least add the option of pulling field constants from this data. This will help smooth over the pains of the inevitably erroneous fields at competition.

justbuchanan commented 8 years ago

Here are the protobuf files for ssl vision: https://github.com/RoboCup-SSL/ssl-vision/tree/master/src/shared/proto

And here's the part of our code where we read the vision packets: https://github.com/RoboJackets/robocup-software/blob/master/soccer/Processor.cpp#L298

Also take a look at #335

jgkamat commented 8 years ago

Are these packets implemented in our simulator? I tried out a basic setup and I'm getting 0 for width/height. https://github.com/RoboJackets/robocup-software/commit/592739285db0eab2823f383b01eac7dcb3df5efd

barulicm commented 8 years ago

The simulator sends packets, but it might not fill out all of the fields. So they're atleast partially implemented.