search

RoboMWM / GPAuctions

1 stars 3 forks source link

For AutoAuctions, destroy the auction sign on Auction Close. #45

Closed NullCase closed 5 years ago

NullCase commented 5 years ago

Presently, the auction sign is recoverable when broken.

I would like those AutoAuction signs to vanish when they are broken.

Note: The ones placed by players are legitimate signs and I want those to be recovered when broken, but AutoAuction signs are kinda cheaty because they're created out of thin air.

RoboMWM commented 5 years ago

Would it be better to destroy the auction sign after the auction closes? Otherwise I'd have to store locations of auto-generated signs and await a break event to delete the corresponding drop.

NullCase commented 5 years ago

After it closes. Yep if that's easier let's do that.

NullCase commented 5 years ago

Sign not destroyed on AutoAuction close:

test: two AutoAuctions: one with bidders, one without. Wait for both to close. result: neither sign destroyed. expected: both signs destroyed.

NullCase commented 5 years ago

idk, just had a thought.

do you think this sign placement function will break in 1.14? because of the new signs.

RoboMWM commented 5 years ago

There's more new signs in 1.14?

I don't see any reason why the Sign blockstate would change though.

Anyways, I guess changing the type in the blockstate isn't a valid way to remove a block. I just released a commit that changes the block type the standard way.

NullCase commented 5 years ago

Fixed.