search

RoboSats / robosats

A simple and private bitcoin exchange
https://learn.robosats.com
GNU Affero General Public License v3.0
695 stars 135 forks source link

Telegram notifications #1136

Open gabbygator184 opened 6 months ago

gabbygator184 commented 6 months ago

Describe the bug When an order is taken and the maker robot enabled telegram notifications, the maker will receive a link via telegram to open the order in the browser and proceed. If a new Tor Browser is opened, this link will guide the user to the order screen, but without the robot token loaded.

The user might think the page is loading because he is waiting the blue spinner to disappear, but in fact an error is occurring in the backend. If the robot token is not informed, the order will be closed and the user will lose the bond.

To Reproduce Steps to reproduce the behavior:

  1. Create an order and enable telegram notifications
  2. Close Tor Browser
  3. Take the order with a new robot and close Tor Browser
  4. Open the link received via telegram in Tor Browser
  5. The order won't open (as expected) and the screen shows the blue spinner.

Expected behavior An error message should be shown if someone try to open an order address without robot token or ask for the robot token.

Desktop (please complete the following information):

Reckless-Satoshi commented 6 months ago

We should display the "You need to generate an avatar" Dialog anytime someone lands on /order/... without a robot.

nikkuAg commented 5 months ago

Hey, is this issue still open? I would like to work on this