Closed jerryfletcher21 closed 3 months ago
This PR is solid and complete. We will be merging #1326 instead given that it implements the frontend fixes and has integration tests as well. But a few things from this PR can be implemented there for the best of both worlds 😄
Makes sense to split the reward as discussed on #1326. Please post an invoice for 40K Sats (+ week expiration if possible) 🚀
Closing.
Sure, perfectly fine with me, I left some comments in #1326
40K Sats (+ week expiration if possible) 🚀
Feel free to post the invoice in this threat or in the issue. Thank you!
What does this PR do?
This PR introduces a new optional parameter
current_status
that can be used when cancelling an order. The server checks ifcurrent_status
is the correct status of the order and returns an error without cancelling the order if it is not. This way a client can be sure to cancel an order just if the status is the one it specified. Fixes backed and tests of #1311.Checklist before merging
pip install pre-commit
, thenpre-commit install
. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.