verify_signed_message was not checking for the validity of the signature. The documentation of python-gnupg is not clear about this, it says that the fields returned by verify are set just if the signature is valid. In this case tests/robots/1/signed_message was signed with the correct key but with the wrong digest-algo (SHA256 instead of SHA512) as expressed on the signature.
Running gpg --verify tests/robots/1/signed_message after importing the key returned:
gpg: WARNING: signature digest conflict in message
gpg: Can't check signature: General error
and a non zero error code. Changing Hash: SHA256 in tests/robots/1/signed_message returned no errors.
verify_signed_message called in test_verify_signed_message in api/tests/test_utils.py was not catching this because verified.fingerprint was set even though verified.valid was False.
I have recreated the signature with SHA512 by running:
[x] Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.
What does this PR do?
verify_signed_messagewas not checking for the validity of the signature. The documentation ofpython-gnupgis not clear about this, it says that the fields returned byverifyare set just if the signature is valid. In this casetests/robots/1/signed_messagewas signed with the correct key but with the wrong digest-algo (SHA256instead ofSHA512) as expressed on the signature. Runninggpg --verify tests/robots/1/signed_messageafter importing the key returned:and a non zero error code. Changing
Hash: SHA256intests/robots/1/signed_messagereturned no errors.verify_signed_messagecalled intest_verify_signed_messageinapi/tests/test_utils.pywas not catching this becauseverified.fingerprintwas set even thoughverified.validwasFalse.I have recreated the signature with
SHA512by running:Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.