search

RoboSense-LiDAR / rslidar_sdk

RoboSense LiDAR SDK for ROS & ROS2
Other
457 stars 219 forks source link

Loading config path from ROS2 parameter #103

Closed sagocz closed 1 month ago

sagocz commented 1 year ago

Previously, you added a feature to load config file path from ROS1 parameter, but you omitted ROS2. This feature is necessary to properly load the configuration file, which is placed outside the package location in ROS2. I have also added printing out information, from what path the configuration file is currently loaded. I created pull request with my solution for that.

Timple commented 1 year ago

See PR https://github.com/RoboSense-LiDAR/rslidar_sdk/pull/52, this was merged by them. But they secretly modified the parameter name without documentation :wink: so this isn't obvious for users who transition from ROS1.

sagocz commented 1 year ago

See PR #52, this was merged by them. But they secretly modified the parameter name without documentation wink so this isn't obvious for users who transition from ROS1.

Maybe I'm blind, but what I can see, they only merged parameter from ROS1 and skipped ROS2. -> link

Timple commented 1 year ago

You're right!

JWhitleyWork commented 1 year ago

Can we PLEASE get this merged?

wienans commented 1 year ago

Would like to have this merged too.

FelixHuang18 commented 1 month ago

We have merged your PR to the dev_opt branch. Thanks to everyone.

FelixHuang18 commented 1 month ago

close the PR.

Timple commented 1 month ago

What's the branching policy you are using if I may ask?

I see: main, dev, dev-opt and release. From the naming it isn't obvious which is 'the best'.

FelixHuang18 commented 1 week ago

@Timple I have deleted the unnecessary branches, and now only the main and dev_opt branches remain. The dev_opt branch is for development. Once development is complete, it will be merged into the main branch.