Rename `client` to `service_client`

RoboStack / jupyter-ros

Jupyter widget helpers for ROS, the Robot Operating System

https://jupyter-ros.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

585 stars 114 forks source link

Rename `client` to `service_client` #117

Closed IsabelParedes closed 2 years ago

IsabelParedes commented 2 years ago

With this PR, client is renamed to service_client to maintain consistency and avoid confusion with the action_client. This change is updated in the example notebook and the documentation.

Additionally, error handling is improved for when the service is not available and a minor typo is corrected in the actions client (for consistency).

wolfv commented 2 years ago

LGTM!

hbcarlos commented 2 years ago

Thanks, @ihuicatl!