search

RoboStack / jupyter-ros

Jupyter widget helpers for ROS, the Robot Operating System
https://jupyter-ros.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
585 stars 115 forks source link

[feature request] support bag files #13

Closed flixr closed 5 years ago

flixr commented 5 years ago

This looks really promising!

However instead of accepting live data, IMHO a more common use case for jupyter is to analyze recorded data. So in the ROS context that usually means bag files.

It would be great to have good support for bag files.

https://github.com/cruise-automation/webviz could be useful here as well.

wolfv commented 5 years ago

Thanks for the suggestion! Indeed, a bag player of some sort would be very useful, and probably not too hard to implement. If you are willing to give it a go, I can help you out!

The easiest would be to write it in python, and hook up some ipywidget Buttons to start/stop the playback, and then run the playback in a background python thead.

HemaZ commented 5 years ago

I will work on this feature. @wolfv could you please assign it to me? Thank you.

wolfv commented 5 years ago

@HemaZ That's awesome. Can't seem to be able to assign you from the button (did you disable that feature?).

Anyways, let me know how it goes. I am happy to help out with this.

HemaZ commented 5 years ago

@wolfv just opened the PR. please check it, and feel free to ask for any modifications. i don't know if this is the best approach to implement it. but it works :D Screenshot-20190415214614-1073x524

wolfv commented 5 years ago

Initial bag file support has been merged!