search

RoboStack / ros-foxy

ros foxy vinca files
8 stars 12 forks source link

fix for seg fault tf2_py #4

Open sonelu opened 3 years ago

sonelu commented 3 years ago

Attempts to fix #3

sonelu commented 3 years ago

@wolfv Actually I'm a little confused about how to name the patch in respect to the relative info in the diff.

Should it be ros-foxy-geometry2.patch with the current info in the patch?

or

Should be ros-foxy-tf2_py.patch and remove /tf2_py in the diff part in the patch?

or

Should be ros-foxy-geometry2-tf2_py.patch and remove /tf2_py in the diff line in the patch?

Tobias-Fischer commented 3 years ago

Hi @sonelu, thanks for this! The name of the file should be ros-foxy-tf2-py.patch. It uses the same name as in the rosdistro distribution file (in this case, https://github.com/ros/rosdistro/blob/master/foxy/distribution.yaml), and replaces _ with -. And yes, please remove the /tf2_py prefix in the diff itself.

@wolfv - at some point we should setup CI for PRs in Foxy as well.

Tobias-Fischer commented 3 years ago

By the way, @sonelu did you locally check whether this patch fixes the segfault?

sonelu commented 3 years ago

No, I haven't been able to, yet. I have a problem with building tf2_msg. I'm getting:

(ros2) Alex3-2:ros2_ws Alex$ colcon build
Starting >>> tf2     
Starting >>> tf2_msgs
--- stderr: tf2_msgs                                                             
CMake Error at /Users/Alex/anaconda3/envs/ros2/share/rosidl_typesupport_c/cmake/get_used_typesupports.cmake:35 (message):
  No 'rosidl_typesupport_c' found
Call Stack (most recent call first):
  /Users/Alex/anaconda3/envs/ros2/share/rosidl_typesupport_c/cmake/rosidl_typesupport_c-extras.cmake:8 (get_used_typesupports)
  /Users/Alex/anaconda3/envs/ros2/share/rosidl_typesupport_c/cmake/rosidl_typesupport_cConfig.cmake:41 (include)
  /Users/Alex/anaconda3/envs/ros2/share/rosidl_default_generators/cmake/rosidl_default_generators-extras.cmake:21 (find_package)
  /Users/Alex/anaconda3/envs/ros2/share/rosidl_default_generators/cmake/rosidl_default_generatorsConfig.cmake:41 (include)
  CMakeLists.txt:13 (find_package)

---
Failed   <<< tf2_msgs [0.98s, exited with code 1]
Aborted  <<< tf2 [1.03s]

By the way, I had to install rosidl_typesupport_c package as is was not installed by the ros-foxy-base. I'm a little confused by these rosidl packages as I haven't used ROS2 yet.

newcanopies commented 3 years ago

Hi, thanks for the work on this PR

I have seemingly the same issue building control_msgs, on Ubuntu 20.04 ROS2 Foxy

~/ws_ROS2$ colcon build --symlink-install --packages-select control_msgs

Starting >>> control_msgs
--- stderr: control_msgs                         
CMake Error at /opt/ros/foxy/share/rosidl_typesupport_c/cmake/get_used_typesupports.cmake:35 (message):
  No 'rosidl_typesupport_c' found
Call Stack (most recent call first):
  /opt/ros/foxy/share/rosidl_typesupport_c/cmake/rosidl_typesupport_c-extras.cmake:8 (get_used_typesupports)
  /opt/ros/foxy/share/rosidl_typesupport_c/cmake/rosidl_typesupport_cConfig.cmake:41 (include)
  /opt/ros/foxy/share/rosidl_default_generators/cmake/rosidl_default_generators-extras.cmake:21 (find_package)
  /opt/ros/foxy/share/rosidl_default_generators/cmake/rosidl_default_generatorsConfig.cmake:41 (include)
  CMakeLists.txt:15 (find_package)

---
Failed   <<< control_msgs [3.05s, exited with code 1]

Summary: 0 packages finished [3.39s]
  1 package failed: control_msgs
  1 package had stderr output: control_msgs
wolfv commented 3 years ago

@newcanopies you're not using the RoboStack packages, right? Did you use the standard way of installing ors-foxy on Ubuntu?

I think you might need to install ros-foxy-rosidl-typesupport-c?

newcanopies commented 3 years ago

you're not using the RoboStack packages, right? Did you use the standard way of installing ors-foxy on Ubuntu?

Thanks @wolfv Yes to both. I am just trying to build core ros2 packages in a master $COLCON_ws on a standard foxy install.

I tried installing rosidl package, is that where ros-foxy-rosidl-typesupport-cwould come from? image

wolfv commented 3 years ago

I am imagining you can do apt install ros-foxy-rosidl-typesupport-c?

Tobias-Fischer commented 3 years ago

I'd suggest to keep @newcanopies's issue separate - it doesn't seem related to tf2_py at all, and doesn't use robostack either.

newcanopies commented 3 years ago

no problem Tobias-Fischer, leaving this below for others who might find this thread by searching for: No 'rosidl_typesupport_c' found

since it is installed on the system:

sudo apt install ros-foxy-rosidl-typesupport-c

Reading package lists... Done
Building dependency tree       
Reading state information... Done
ros-foxy-rosidl-typesupport-c is already the newest version (1.0.2-1focal.20210415.021333).
ros-foxy-rosidl-typesupport-c set to manually installed.
The following packages were automatically installed and are no longer required:
  python3-xkit ubuntu-drivers-common
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 8 not upgraded.