search

RoboStack / ros-galactic

Vinca build files for ROS 2 Galactic Geochelone
https://robostack.github.io
21 stars 14 forks source link

In Galactic sdformat points to sdformat9, i.e. libsdformat conda-forge package #100

Open traversaro opened 2 years ago

traversaro commented 2 years ago

This should avoid the problem discussed in https://github.com/conda-forge/libsdformat-feedstock/pull/57#issuecomment-1093535795 . sdformat12 (libsdformat12 conda-forge package) is going to be used in Humble instead, see https://github.com/ros/sdformat_urdf/pull/7 .

Tobias-Fischer commented 2 years ago

Ok - will merge this in when we next rebuild all packages.

Thanks @traversaro

traversaro commented 2 years ago

Ok - will merge this in when we next rebuild all packages.

Thanks @traversaro

Ack, I tried to enable sdformat-urdf for linux-64 in this PR just to check if it builds fine. Fortunatly the sdformat rosdep key should be used only there, see https://index.ros.org/d/sdformat/ .

traversaro commented 2 years ago

Ok - will merge this in when we next rebuild all packages. Thanks @traversaro

Ack, I tried to enable sdformat-urdf for linux-64 in this PR just to check if it builds fine. Fortunatly the sdformat rosdep key should be used only there, see https://index.ros.org/d/sdformat/ .

Indeed, sdformat-urdf seems to be building fine even against sdformat 9.

Tobias-Fischer commented 2 years ago

I guess we should do the same on Noetic at some point ..

traversaro commented 2 years ago

I guess we should do the same on Noetic at some point ..

Done in https://github.com/RoboStack/ros-noetic/pull/253 .