RoboStack / ros-galactic

Vinca build files for ROS 2 Galactic Geochelone
https://robostack.github.io
21 stars 14 forks source link

Add rosbridge_suite to osx and osx_arm64 #108

Closed defunctzombie closed 2 years ago

defunctzombie commented 2 years ago

@Tobias-Fischer I see that you are having to tweak some patches for this change. I am surprised that this rviz stuff is related? Maybe it would be easier to track down why rosbridge is wanting to bring in this other package and patch that out of the dependency chain?

Tobias-Fischer commented 2 years ago

@defunctzombie - the build pipeline is setup so that packages are rebuilt if new versions are available. I think I fixed the patches for all packages now, let's see how the build goes.

Tobias-Fischer commented 2 years ago

Hm actually I agree with you, I'm not sure why these additional packages are build. It doesn't happen locally. I'll merge and see what happens.

Any ideas @wolfv?

Tobias-Fischer commented 2 years ago

@defunctzombie - the build now fails with errors in the rosbridge_suite. Could you please have a look? See in the repo under the buildbranch_osx branch.

Tobias-Fischer commented 2 years ago

Actually just ignoring the test msgs package, that seems to work fine.

Tobias-Fischer commented 2 years ago

Had another look - due to changes in the rosidl_generator_c package, we need a complete rebuild of all packages :(

/Cc @wolfv

Tobias-Fischer commented 2 years ago

Not sure if it's worth it, or if we should focus on humble ..

defunctzombie commented 2 years ago

@Tobias-Fischer somewhat related to evergreen builds - is there a rolling version of robostack that points to the latest set of packages?

Tobias-Fischer commented 2 years ago

No, not yet ..

Tobias-Fischer commented 2 years ago

@defunctzombie - feel free to add rosbridge_suite to our humble pipeline. It should build without issues there.