RoboStack / ros-galactic

Vinca build files for ROS 2 Galactic Geochelone
https://robostack.github.io
21 stars 14 forks source link

Nav2 on Win #57

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 2 years ago

This fails because of a weird error:

2021-10-26T01:21:34.9857853Z CMake Error at C:/Miniconda/conda-bld/ros_1635210099861/_h_env/Library/share/bondcpp/cmake/ament_cmake_export_libraries-extras.cmake:48 (message):
2021-10-26T01:21:34.9859907Z   Package 'bondcpp' exports the library 'bondcpp' which couldn't be found
2021-10-26T01:21:34.9860800Z Call Stack (most recent call first):
2021-10-26T01:21:34.9861709Z   C:/Miniconda/conda-bld/ros_1635210099861/_h_env/Library/share/bondcpp/cmake/bondcppConfig.cmake:41 (include)
2021-10-26T01:21:34.9862557Z   CMakeLists.txt:18 (find_package)
Tobias-Fischer commented 2 years ago

It probably needs an EXPORT_ALL_SYMBOLS in bondcpp to work.

@ooeygui do you have any plans to work on the navigation stack?

Tobias-Fischer commented 2 years ago

Added a bunch of patches from https://github.com/ros-planning/navigation2/compare/1.0.7...galactic

Tobias-Fischer commented 2 years ago

You might like this @ooeygui @wolfv - seems like we got nav2 working (at least a significant chunk of it)!

Tobias-Fischer commented 2 years ago

Okay .. I got a bit further, but now I'm stuck. It fails with errors like

%PREFIX%\Library\include\GraphicsMagick\Magick++/Drawable.h(132,17): error C2039: 'unary_function': is not a member of 'std' [%SRC_DIR%\build\map_io.vcxproj]

It's fixed in GraphicsMagick upstream, but they haven't released a new version for nearly a year. I'm not sure what the best way to go about this is .. what do you think @wolfv?

wolfv commented 2 years ago

Can we ask the graphicsmagick maintainers? If it's not a super-intrusive patch we could also try to patch graphicsmagick but a release would probably be better.

wolfv commented 2 years ago
#if __cplusplus < 201703L
#  define MAGICK_UNARY_FUNCTION_IMAGE_REF_BASE \
  : public std::unary_function<Image&,void>
#else
#  define MAGICK_UNARY_FUNCTION_IMAGE_REF_BASE
#endif // if __cplusplus < 201703L

... maybe that's already enough? We coudl try patching graphicsmagick with this.

Also I just saw that you asked in the project 👍

Tobias-Fischer commented 2 years ago

Unfortunately not quite as easy, but here we go: https://github.com/conda-forge/graphicsmagick-feedstock/pull/15

wolfv commented 2 years ago

cool!