Fix Windows build after PR 75

[traversaro]

See https://github.com/RoboStack/ros-galactic/pull/75#issuecomment-1079617199 .

(Just opening an issue to have a place were to report progress).

[traversaro]

Slight change of instruction to reproduce the problem from https://github.com/RoboStack/ros-galactic/pull/75#issuecomment-1077429858 (just changing cp to copy to run on Command Prompt):

mamba create -n testenv python=3.9 pip rospkg networkx "catkin_pkg>=0.4.16" "ruamel.yaml>=0.16.6" "rosdistro>=0.8.0" "empy>=3.3.4" boa=0.9
mamba activate testenv
pip install git+https://github.com/RoboStack/vinca.git --no-deps
cd /path/to/ros-galactic
copy vinca_win.yaml vinca.yaml
vinca --platform win-64
boa build additional_recipes/ros2-distro-mutex/ -m ./.ci_support/conda_forge_pinnings.yaml -m ./conda_build_config.yaml
boa build . -m ./.ci_support/conda_forge_pinnings.yaml -m ./conda_build_config.yaml

[traversaro]

I started locally and the build seems to be working fine. I wonder if it is a Git Bash/Command Prompt problem, in that case I can switch the CI To use Command Prompt.

[traversaro]

Upstreamed patches:

• Part of https://github.com/ros-planning/navigation2/pull/2672
• https://github.com/ros-planning/navigation2/pull/2603/files
• https://github.com/ros2/geometry2/pull/349

[traversaro]

I see a failure in https://dev.azure.com/robostack/ros_pipelines/_build/results?buildId=3657&view=logs&j=89dee4d5-4df7-5a48-779f-4e93227829ad&t=e7271866-09c5-508a-c818-752c9bc38af5 , probably boa switched from master to main.

[traversaro]

I see a failure in https://dev.azure.com/robostack/ros_pipelines/_build/results?buildId=3657&view=logs&j=89dee4d5-4df7-5a48-779f-4e93227829ad&t=e7271866-09c5-508a-c818-752c9bc38af5 , probably boa switched from master to main.

Hopefully fixed by https://github.com/RoboStack/vinca/pull/32 .

[traversaro]

Now the Windows azure build is failing (see https://dev.azure.com/robostack/ros_pipelines/_build/results?buildId=3663&view=logs&j=89dee4d5-4df7-5a48-779f-4e93227829ad&t=e7271866-09c5-508a-c818-752c9bc38af5) with:

Installing collected packages: wcwidth, json5, commonmark, sniffio, pygments, prompt-toolkit, joblib, rich, anyio, watchgod, boa
Successfully installed anyio-3.5.0 boa-0.10.0 commonmark-0.9.1 joblib-1.1.0 json5-0.9.6 prompt-toolkit-3.0.28 pygments-2.11.2 rich-12.0.1 sniffio-1.2.0 watchgod-0.8.1 wcwidth-0.2.5
"BUILDING RECIPE ros2-distro-mutex"

|   299             o.finalize_solve(sorted_outputs)                          |
|   300                                                                       |
|   301             meta = MetaData(recipe_path, o)                           |
| > 302             o.set_final_build_id(meta)                                |
|   303                                                                       |
|   304             if o.skip() or full_render:                               |
|   305                 continue                                              |
| C:\Miniconda\lib\site-packages\boa\core\recipe_output.py:576 in             |
| set_final_build_id                                                          |
|                                                                             |
|   573                     # remove self-run-exports for static packages     |
|   574                     run_exports_list[:] = []                          |
|   575                 else:                                                 |
| > 576                     x.eval_pin_subpackage([self])                     |
|   577                                                                       |
|   578                 x.eval_pin_subpackage([self])                         |
|   579             run_exports_list[:] = [x.final for x in run_exports_list] |
|                                                                             |
| C:\Miniconda\lib\site-packages\boa\core\conda_build_spec.py:161 in          |
| eval_pin_subpackage                                                         |
|                                                                             |
|   158             self.final = f"{pkg_name} {version} {build_string}"       |
|   159         else:                                                         |
|   160             version_parts = version.split(".")                        |
| > 161             count_pin = self.pin.max_pin.count(".")                   |
|   162             version_pin = ".".join(version_parts[: count_pin + 1])    |
|   163             version_pin += ".*"                                       |
|   164             self.final = f"{pkg_name} {version_pin}"                  |
+-----------------------------------------------------------------------------+
AttributeError: 'NoneType' object has no attribute 'max_pin'
##[error]Cmd.exe exited with code '1'.

This is similar to the issue fixed in https://github.com/mamba-org/boa/pull/268 .

[Tobias-Fischer]

Unfortunately the Azure build fails for mimick in the same way as on GA. I think building locally for now is the way to go.

[traversaro]

Here is a locally built package (compressed to .zip for loading in GitHub issues, but it was a bz2 originall): ros-galactic-mimick-vendor-0.2.6-py39he8739fe_3.tar.zip . For logs do you need the one from the terminal or something else?

[Tobias-Fischer]

Thanks @traversaro - I just uploaded it to https://anaconda.org/robostack-experimental/ros-galactic-mimick-vendor/files and will trigger a build of the remaining packages :)

[traversaro]

ros-galactic-desktop is still missing, do we need to enable it in vinca_win.yaml? See also https://github.com/RoboStack/ros-galactic/issues/74#issuecomment-1084413198 .