RoboStack / ros-galactic

Vinca build files for ROS 2 Galactic Geochelone
https://robostack.github.io
21 stars 14 forks source link

Create activate scripts for PowerShell #91

Closed doriantsai closed 1 year ago

doriantsai commented 2 years ago

I am trying to get Robostack to work in with Windows 10 Powershell and running into an error. Will post it shortly.

Tobias-Fischer commented 2 years ago

See also https://github.com/RoboStack/ros-noetic/issues/21

@traversaro - you mentioned that it should be easy-ish to create the ps1 script in vinca. Do you have any documentation that we could look at?

traversaro commented 2 years ago

@traversaro - you mentioned that it should be easy-ish to create the ps1 script in vinca. Do you have any documentation that we could look at?

Not sure, but apparently both colcon and ros2 docs mention .ps1 activation scripts:

That is the reason why I was more optimistic of supporting PowerShell on ROS2 then on ROS1, as mentioned in https://github.com/RoboStack/ros-noetic/issues/21 .

traversaro commented 2 years ago

For the vinca part, probably we will just modify around this line: https://github.com/RoboStack/vinca/blob/d38d89fcf2d46ea8e62aff31e76bbfb7fe95d028/vinca/template.py#L89 and add the approriate templates in https://github.com/RoboStack/vinca/tree/d38d89fcf2d46ea8e62aff31e76bbfb7fe95d028/vinca/templates . Porting to ps1 https://github.com/RoboStack/vinca/blob/d38d89fcf2d46ea8e62aff31e76bbfb7fe95d028/vinca/templates/activate.bat.in and https://github.com/RoboStack/vinca/blob/d38d89fcf2d46ea8e62aff31e76bbfb7fe95d028/vinca/templates/deactivate.bat.in may be a good starting point.