search

RoboStack / ros-humble

Recipes for ROS 2 Humble Hawksbill
85 stars 33 forks source link

Add turtlebot3 & turtlebot3_gazebo to all targets #54

Closed nikolausWest closed 1 year ago

nikolausWest commented 1 year ago

Closes #53

nikolausWest commented 1 year ago

@traversaro: I have no idea how to fix the Windows issue. Is the best way forward to just remove the additions to the Windows target?

traversaro commented 1 year ago

@traversaro: I have no idea how to fix the Windows issue. Is the best way forward to just remove the additions to the Windows target?

I would say that it is the way to go, even because the failure seems related to ros-humble-slam-toolbox, but probably @Tobias-Fischer can add something on this.

traversaro commented 1 year ago

Based on https://github.com/RoboStack/ros-noetic/issues/78#issuecomment-799852755 it seems that slam_toolbox is unlikely to work on Windows anyhow, as it uses a lot of Unix-specific functions.

nikolausWest commented 1 year ago

Alright, will drop Windows then. Thanks @traversaro!

Tobias-Fischer commented 1 year ago

I think we are now stuck with #45 on Windows. Let's see what happens ;).

Tobias-Fischer commented 1 year ago

Seems like it worked - thanks for your contribution @nikolausWest and all the best for rerun.io, looks cool. Let us know if you need anything else from RoboStack :)

nikolausWest commented 1 year ago

Thanks @Tobias-Fischer! That was super fast, really appreciate it!