Closed marcoesposito1988 closed 5 months ago
Thanks @marcoesposito1988, I think that indeed your first guess is the correct one. Are you interesting in submitting a PR to fix the issue? Thanks in advance!
Hi @traversaro, sure, I'll give it a shot.
Could you please point me to where you list the git repositories to check out and select the branch/commit? I didn't manage to find that in the code so far
Details can be found in https://github.com/RoboStack/ros-noetic/blob/master/CONTRIBUTING.md . In a nutshell, you can open a PR upstream, and extract the patch related to that change by adding .patch
to the end of the PR. Then you can add the patch (or update the existing patch) in https://github.com/RoboStack/ros-noetic/tree/master/patch .
PR is now open (#383). This is the workflow I used:
vinca --multiple
)yaml
file to only build moveit-ros-planning
boa build...
run, which it failed, but only after applying the patchesC:\Users\...\mambaforge\envs\robostackenv\conda-bld\ros-noetic-moveit-ros-planning-...\work\ros-noetic-moveit-ros-planning\src\work\moveit_cpp
git diff
Does it sound reasonable? Is there a more streamlined one? If so we could add it to CONTRIBUTING.md
Does it sound reasonable? Is there a more streamlined one? If so we could add it to CONTRIBUTING.md
It seems reasonable to me, even if @Tobias-Fischer may have some input on this. Anyhow, it seems to me something valuable to add to CONTRIBUTING.md, thanks!
That looks great, yes!
Cool, thanks! I will open a PR for the docs then, good thing we don't need the CI for that :see_no_evil:
Would it be possible to release the package again? I created a new environment, and the library is still missing so MoveIt is still unusable on Windows.. 😬
Will be part of https://github.com/RoboStack/ros-noetic/pull/418
Solution to issue cannot be found in the documentation.
Issue
It is impossible to start a MoveIt! instance (e.g. roslaunch moveit_resources_panda_moveit_config demo.launch) because
move_group.exe
crashes due tomoveit_cpp.dll
not being found.The DLL is part of moveit-ros-planning and indeed the
moveit_cpp.lib
file is present in..\noetic_env\Library\lib
after installingros-noetic-moveit-ros
.I already deleted and recreated the conda environment from scratch today.
My guess is that either:
RUNTIME DESTINATION
is missing here and should be added in a robostack patchInstalled packages
Environment info