search

RoboStack / ros-noetic

vinca configuration files for ros-noetic
https://robostack.github.io
464 stars 73 forks source link

remove outdated patch #416

Closed lianghongzhuo closed 8 months ago

lianghongzhuo commented 11 months ago

pr according to: https://github.com/RoboStack/ros-noetic/issues/411

Tobias-Fischer commented 11 months ago

We should rebuild those packages to see if the patches are indeed not needed anymore.

lianghongzhuo commented 11 months ago

I built the python 3.11 Linux 64 version without these patches successfully. See: https://github.com/lianghongzhuo/ros-noetic/blob/dev/docs/noetic.md

lianghongzhuo commented 11 months ago

But I am not sure if they are not needed in other os

traversaro commented 11 months ago

A lot of the patches are Windows-specific, without a test on Windows probably it is not super safe to delete them.