search

RoboStack / ros-noetic

vinca configuration files for ros-noetic
https://robostack.github.io
464 stars 73 forks source link

Fix cv_bridge CMake exports #426

Closed peci1 closed 8 months ago

Tobias-Fischer commented 11 months ago

Have you tried locally to see whether this achieves the desired effect?

peci1 commented 11 months ago

Yes, I'm trying right now. It does not. I'm figuring out what's wrong.

It seems to be a bug in the ported catkin patch: https://github.com/ros/catkin/pull/1142#discussion_r1371629543 .

peci1 commented 11 months ago

Also, keeping the find_package(OpenCV 4 QUIET) is important. It pulls all installed OpenCV libs into OpenCV_LIBRARIES, and the second call with required components just appends those components. I think the logic is: "provide as many libraries as possible, but fail if at least the two listed components are not present".

peci1 commented 11 months ago

@Tobias-Fischer This should fix #424, but I don't understand the mac and win segfaults. I also did the ruamel.yaml fix for GH Actions PRs.

aravindsiv commented 8 months ago

Hi @peci1 ,

I want to use this patch since I'm facing a similar issue to #424 (I have OpenCV missing symbol errors with cmake). What would be the best way to go about this?

peci1 commented 8 months ago

Hi, I'm not able to help here. You would probably need to build the packages locally, but how to do that is a question I can't answer. You should read the documentation and try to understand the local build process.

Tobias-Fischer commented 8 months ago

I've added this fix to #418