search

RoboStack / ros-noetic

vinca configuration files for ros-noetic
https://robostack.github.io
448 stars 70 forks source link

Package request: depthai-ros #469

Open kneave opened 2 months ago

kneave commented 2 months ago

Package name

depthai-ros

Operating System(s)

Additional context (optional)

This is the ROS package for the DepthAI range of cameras and would be incredible handy to have available in RoboStack please to enable much easier use of this, especially on SBC like the Raspberry Pi where building packages can be a bit of a nightmare.

Links and references (optional)

https://github.com/luxonis/depthai-ros

traversaro commented 1 month ago

Just by chance, I started working with depthai-core (not ROS) at my job (see https://github.com/luxonis/depthai-core/issues/1021 and https://github.com/luxonis/depthai-core/issues/754#issuecomment-2106927167), and I found that it uses hunter to deal with C++ dependencies, and it is not obvious to me how that interacts with apt and/or conda. Do you have any pointer on how depthai-ros is packaged in the ROS buildfarm?

See also https://github.com/RoboStack/ros-noetic/issues/151 for a related old discussion on this.

traversaro commented 1 month ago

See also #151 for a related old discussion on this.

Actually that discussion refer to https://github.com/rapyuta-robotics/depthai_ros/, while this to discussion to https://github.com/luxonis/depthai-ros, not sure how the two are related.

kneave commented 1 month ago

Hi Traversaro, I'm going to be completely honest and say I've no idea how the buildfarm handles these things. I started to look at setting one up so I could get packages built for the Raspberry Pi easier but then discovered robostack 😅

I'd be happy to learn if it could help but I'm just not sure where to start.

traversaro commented 1 month ago

Cool, thanks!

Just some pointer I found:

Given that, I guess we could simply try to add depthai-ros as a package, and check if the CI is able to do built it. You can follow the instructions on how to prepare a PR to add depthai-ros in https://robostack.github.io/Contributing.html, then we will se in the PR CI if the package builds fine or not.

kneave commented 1 month ago

Done :) https://github.com/RoboStack/ros-noetic/pull/471

If it is this easy it'd be a win, but life rarely is! 😅

kneave commented 1 month ago

Looks like Tobias may have beaten us to it a few weeks ago though! https://github.com/RoboStack/ros-noetic/actions/runs/8902332643

traversaro commented 1 month ago

Looks like Tobias may have beaten us to it a few weeks ago though! https://github.com/RoboStack/ros-noetic/actions/runs/8902332643

Good point, let's cross link to avoid forgetting about it: https://github.com/RoboStack/ros-noetic/pull/470 .

traversaro commented 1 month ago

Also https://github.com/RoboStack/ros-noetic/pull/441#issuecomment-1913420942 is related.