search

RoboStack / ros-noetic

vinca configuration files for ros-noetic
https://robostack.github.io
448 stars 70 forks source link

Add proper match * to ros-distro-mutex dependencies #476

Closed traversaro closed 1 month ago

traversaro commented 1 month ago

At some point in the past, conda-build/boa went from translating gazebo 11 from gazebo==11.* to gazebo==11.0.0. I am not sure when this happened, but for sure it is better to be less ambiguous and clearly indicate that we are constraining just the versions indicated, not the one not indicated.

With a re-build of ros-distro-mutex this should fix https://github.com/RoboStack/ros-noetic/issues/475 .

traversaro commented 1 month ago

Thanks @Tobias-Fischer ! Given that we bumped the build number, do you think in the future we could keep the old ros-distro-mutex around? It is not clear to me how it got removed, you remove them to ensure that the new one got actually updated? Not sure how to do, but it would be great to avoid removing old packages to avoid pixi environments to break.

Tobias-Fischer commented 1 month ago

Hmm I’m not sure - I haven’t done anything .. which particular build is missing?

traversaro commented 1 month ago

Hmm I’m not sure - I haven’t done anything .. which particular build is missing?

See https://anaconda.org/robostack-staging/ros-distro-mutex/files, the build _6 (that is the one with the problem that was fixed by this PR) disappeared, and only the _7 remained. Looking at the log https://github.com/RoboStack/ros-noetic/actions/runs/9292257664/job/25572733390 this message seems relevant:

Using Anaconda API: https://api.anaconda.org/
Using "robostack-staging" as upload username
Processing "/opt/conda/build_artifacts/linux-64/ros-distro-mutex-0.5.0-noetic.tar.bz2"
Detecting file type...
File type is "Conda"
Extracting conda attributes for upload
Warning:  Distribution "linux-64/ros-distro-mutex-0.5.0-noetic.tar.bz2" already exists. Removing.
Creating package "ros-distro-mutex"
Creating release "0.5.0"
Uploading file "robostack-staging/ros-distro-mutex/0.5.0/linux-64/ros-distro-mutex-0.5.0-noetic.tar.bz2"

Perhaps the problem is that the filename does not include the build number?

traversaro commented 1 month ago

Probably if we change the build string we need to change also the mutex_package in https://github.com/RoboStack/ros-noetic/blob/1bf89b4610c11f4ebda2e0bcc7891612ae549a60/vinca_osx_arm64.yaml#L2 (used in https://github.com/RoboStack/vinca/blob/519ba61295e10c4b82e6a594a40ae11522c28f51/vinca/main.py#L291-L293) to handle this properly. However, we can only do that in a rebuild.

traversaro commented 1 month ago

I can't tackle this right now, I opened an issue: https://github.com/RoboStack/ros-noetic/issues/477 .