RoboTigers / FRCScout2020

MIT License
1 stars 8 forks source link

Add React Router WIP #25

Closed sharonkass closed 4 years ago

sharonkass commented 4 years ago

Summary

It would be helpful to create restful client routes. This change is just the first step. It sets up the infra and allows us to build on it. Notice that the URL changes when you click into a Tab. These links can be used to navigate our single page application and also can be helpful in placing links in buttons/etc (such as the "Edit" button on the pit report list page). Also these links can be used like any api (from command line curls or browser urls) to get the actual data (json, cvs, whatever) although this will not really be necessary since we will be adding Export button to each report-list page but I still mention it here as a plus.

This is still a Work In Progress. But a PR makes sense so that nothing is lost and we can hopefully avoid painful merge conflicts.

Details

This change sets up the whole app but I've not touched any pit code. For now I will focus on match. Once that is all polished up we can apply to pit (or at same time, no reason to wait really).

Testing

I clicked on each tab from the home page and confirmed that it takes me to the right spot which works and that the proper URL extension was made. (The Match page looks weird, don't worry about that for now)

Spec

We should review the Issue added to this repo for our rest api. This is the first step.

Next Step

I will add the navigation page for matches similar to Pit navigation and will use the routes to get from navigation page to the data collection page. It would help if we could clean up the database design. Please review the Issue for competition-team mapping proposal.