RoboTutorLLC / RoboTutor_2020

Other
3 stars 1 forks source link

Feature request: ignore unknown variables in config.json #107

Open JackMostow opened 2 years ago

JackMostow commented 2 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is: Unknown variables in config.json cause an error (true?).

Describe the solution you'd like A clear and concise description of what you want to happen. Ignore them. Perhaps log the ignored variable and value.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Approach to be followed (optional) A clear and concise description of approach to be followed. Just add a catch-all case to the config.json parser. Also, make sure configuration classes are accessible throughout RoboTutor.

Additional context Configuration classes are located in: https://github.com/RoboTutorLLC/RoboTutor_2020/tree/development/app/src/main/java/cmu/xprize/robotutor/startup/configuration While NSP questions are located in: https://github.com/RoboTutorLLC/RoboTutor_2020/tree/development/comp_questions/src/main/java/cmu/xprize/comp_questions

What is currently in the NSP questions is the config.json is read again with only the necessary NSP-related items since the Configuration classes cannot be accessed in comp_questions