RoboTutorLLC / RoboTutor_2020

Other
3 stars 1 forks source link

Feature request: Identify RoboTutor version by commit timestamp instead of number #129

Closed JackMostow closed 1 year ago

JackMostow commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Version number is hard to maintain and auto-increment.

Describe the solution you'd like A clear and concise description of what you want to happen. Name version by commit timestamp instead of version number.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Approach to be followed (optional) A clear and concise description of approach to be followed.

Additional context Add any other context or screenshots about the feature request here.

JackMostow commented 1 year ago

Also adapt GitHub actions to generate apk for RoboTutor (and RoboFeel) same as for RTFaceLogin.

rishideepc commented 1 year ago

Hello Sir!

I have configured GitHub Actions for RoboTutor_2020. Now a new APK will be generated for RoboTutor_2020, every time a commit is pushed to the repo, and a new workflow is generated!

Thanks - Rishideep!

JackMostow commented 1 year ago

That was fast! Great, but please address comments in code reviews.

rishideepc commented 1 year ago

Thank you Sir! I have addressed the questions in pull request #132.

JackMostow commented 1 year ago

Thanks! I approved your changes, merged into development, and deleted the branch. - Jack

On Sat, Mar 18, 2023 at 12:10 PM Rishideep Chatterjee < @.***> wrote:

Thank you Sir! I have addressed the questions in pull request #132 https://github.com/RoboTutorLLC/RoboTutor_2020/pull/132.

— Reply to this email directly, view it on GitHub https://github.com/RoboTutorLLC/RoboTutor_2020/issues/129#issuecomment-1474889894, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC64MWK2M4IOVJTZXACH4XTW4XM7HANCNFSM6AAAAAAU2OOV4E . You are receiving this because you were assigned.Message ID: @.***>