search

RoboTutorLLC / RoboTutor_2020

Other
3 stars 1 forks source link

2023 03 16 Rishideep - configured GitHub Actions for RoboTutor_2020 #132

Closed rishideepc closed 1 year ago

rishideepc commented 1 year ago
welcome[bot] commented 1 year ago

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request ✨. Make sure to adhere to our Contributing Guidelines.🙌 We will get back to you as soon as we can 😄.

rishideepc commented 1 year ago
  1. This path seems specific to your particular configuration of file folders. Will it work on others? def keystorePropertiesFile = rootProject.file("/home/runner/work/RoboTutor_2020/RoboTutor_2020/app/src/sample_config_files/sample_keystore.properties")
  2. The edit mostly just changed whitespace. Appending ?w=1 to the URL filters them out.

Hello Sir!

The "/home/runner/work/" directory is the default working directory for GitHub Actions workflows during pre-merge checks. The path that I added is an extension of the same. It should work on other machines as well.

rishideepc commented 1 year ago
  1. Shouldn't newApkName include a timestamp? Or is it already part of version?
  2. What does new File("./../../../../../build/", newApkName) assume about the file structure on the machine where the script runs? It seems like an excessively strong assumption liable to break on other machines.

  1. The 'newApkName' holds the default name that is given to the APK that 'build.gradle' generates. Timestamp is included in the 'build-workflow.yml' file, where the built APK is renamed as 'RoboTutor2020-branchName-versionName-timestamp.apk' (I have drawn inspiration from RTFaceLogin, where GitHub Actions was setup in a similar fashion).

  2. It should work on other machines as well, since the 'build.gradle' file stores the generated APK in the mentioned 'build' folder. Once again, the exact same path has also been used in RTFaceLogin's 'build.gradle' file. I have translated the same architecture here.

https://github.com/RoboTutorLLC/RTFace_Login/blob/development/app/build.gradle#L65

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀.