search

RoboTutorLLC / RoboTutor_2020

Other
3 stars 1 forks source link

English prompts in Activity selector missing since 8/25/2020 #30

Closed JackMostow closed 1 year ago

JackMostow commented 3 years ago

The activity selector in https://github.com/RoboTutorLLC/RoboTutor_2020/blob/apk/RoboTutor-back-button-bug-2021-05-02.apk lacks the English prompts present in version 3.3.1.2.
The only 8/25/2020 commit that looks relevant in https://github.com/RoboTutorLLC/RoboTutor_2020/commits/development is 3.4.2.1: fix bug that CTutorAssetManager didn’t unzip all of the assets, which consisted of changing rtVersionName from "3.4.1.2" to "3.4.2.1". Version number format is Milestone release . Feature Release . Patch release . Asset Compatibility INDEX. The comment “TODO: move this out of build so we don't have to rebuild to unzip assets” (which predates the commit) makes me think that changing the asset compatibility index from 2 to 1 might have caused the problem, though I don’t see exactly how.

JackMostow commented 3 years ago

3.3.2.1 activity selector has English prompts but not the "something else" for the top right activity icon.

sushant-varanasi commented 3 years ago

Example of missing English prompt: arithmetic problems that omit "plus" in prompt for e.g. "2 + 2"

Missing narrations caused by problem in mapping narration in animator graph to audio file containing it, I assume.

JackMostow commented 3 years ago

I'm at EDM2021 but plan to upload a logged example after today's last session.

sushant-varanasi commented 3 years ago

I'm at EDM2021 but plan to upload a logged example after today's last session.

Thank you, Dr Mostow. That would be helpful.

JackMostow commented 3 years ago

Describe the bug write.arith_* omits "plus" and "minus" when speaking stimulus -- e.g. it verbalizes 1 + 2 as "one two".

To Reproduce Steps to reproduce the behavior:

  1. In debugger menu for math activities, select _ADD-1D-H.1__it_1
  2. tap START

Expected behavior A clear and concise description of what you expected to happen.

Actual behavior A clear and concise description of how the code performed w.r.t expectations.

Screenshots If applicable, add screenshots to help explain your problem.

Additional details: relevant entry from attached PERF_ log:

{"type":"LOG_DATA","tutor":"write.arith:ADD-1D-H.1__it_1","class":"INFO","tag":"PERFORMANCE_TAG","time":"1625171831634","data":{"timestamp":" 1625171831634"," userId":" DEBUG"," sessionId":" null"," gameId":" b0a76c67-5347-47be-a5d7-ca609ade13b7"," language":" LANG_EN"," tutorName":" word_copy"," tutorId":" write.arith_ADD-1D-H.1__it_1"," matrixName":" math"," levelName":" null"," taskName":" BACKBUTTON"," problemName":" write_7+2"," problemNumber":" 1"," substepNumber":" -1"," substepProblem":" 0"," attemptNumber":" -1"," expectedAnswer":" null"," userResponse":" null"," correctness":" null"," feedbackType":" null"," totalProblemsCount":" 0"," promotionMode":" PROMOTION"," scaffolding":" null"}},

RoboTutor_fftttfNULLf2fffr_3.5.0.1_000009_2021.07.01.16.33.14_6111001342.json.txt PERF_RoboTutor_fftttfNULLf2fffr_3.5.0.1_000009_2021.07.01.16.33.14_6111001342.json.txt

JackMostow commented 3 years ago

To replicate the missing prompt in the activity menu:

  1. Specify "menu_type": "CD2" in config.json. (I neglected to include this step before.)
  2. Launch RoboTutor.
  3. Wait till it starts prompting, e.g. "Stories. _. Let's do the same thing again. I want to stop using RoboTutor." It highlights the option silently instead of saying (if I recall the missing prompt) "something else." Note that this prompt may have been cut because it can be misleading, but it's better than nothing.
sushant-varanasi commented 3 years ago

@JackMostow Sir, my device says, "Reading and writing -> Stories -> Numbers and Math -> Let's do the same thing again -> I want to stop using RoboTutor". I am building the development branch.

JackMostow commented 3 years ago

That's because you're using the CD1 version of the activity menu.
I neglected to specify to set "menu_type": "CD2" in config.json. Sorry!

JackMostow commented 2 years ago

A conspicuous instance of the bug is the absence of the "Please tap" prompt at the start of bpop activities in the English version but not in the Swahili version ("Tafadhali gusa").

gargVader commented 2 years ago

I have been able to reproduce the following two issues

  1. "Reading and writing -> ____ -> Lets do the same thing again - > I want to stop using RoboTutor" in activity selector
  2. Missing "plus" and "minus" for arithmetic problems. Thank you. Will keep posting updates here.
JackMostow commented 2 years ago

See 2022-05-02 Girish: Missing English Prompts for diagnosis (stale cached assets) and cure (timestamp asset files and cached assets).