search

RoboTutorLLC / RoboTutor_2020

Other
3 stars 1 forks source link

Partially Fixed java.lang.NullPointerException #51

Closed Akash-Ramjyothi closed 1 year ago

Akash-Ramjyothi commented 3 years ago

Partially fixes Issue: #31

Description:

This PR partially fixes :

"java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.hashCode()' on a null object reference"

from the Session Table_v3.2_26Apr2019.xlsx table and verified from stack trace. Still trying to fix more crashes listed in the table.

sansyrox commented 3 years ago

@Akash-Ramjyothi , please direct a PR towards the development branch. We don't make PRs to master in this repo.

Akash-Ramjyothi commented 3 years ago

@sansyrox Thank you for informing me, I have directed the PR towards development branch as you asked.

Akash-Ramjyothi commented 3 years ago

Link for Logs: https://travis-ci.com/github/RoboTutorLLC/RoboTutor_2020/builds/227146333

sansyrox commented 3 years ago

@Akash-Ramjyothi , you will have to fetch the latest changes from development for travis to work. Since you branched off master, this won't work.

JackMostow commented 3 years ago

@Akash-Ramjyothi -

  1. Does this May 27 comment mean that this branch came from master rather than development, so rebasing it from development included its commits since mseter?
  2. Does this PR still need to be merged into development to incorporate your bug fix?
  3. Is it safe to merge? What check failed?
JackMostow commented 1 year ago

Only one conflict, but too long to check (100s of lines).