search

RoboZonky / natural-strategy-setup

Webový konfigurátor investiční strategie pro RoboZonky
https://robozonky.github.io/konfigurace-strategie/
2 stars 1 forks source link

Downloaded strategy - follow same format as default Robozonky file #29

Closed Marfusios closed 6 years ago

Marfusios commented 6 years ago

Hello,

it would be great if the downloaded strategy follows default format - robozonky-strategy.cfg (instead of strategy.txt) and UTF-8 encoding (already does).

See issue it has indirectly caused: 181

jhrcek commented 6 years ago

Hello @Marfusios ,

If I understand it right, the only change you're requesting is changing the name of strategy file that's downloaded, right? I fixed that here https://github.com/RoboZonky/natural-strategy-setup/commit/2f283d29496c9eab4d826a14805368249629d0d0 but will deploy the change to the website only after you confirm that that's what you wanted.

Also, just ouf of curiosity, could you please be more specific and explain how it (indirectly) caused the mentioned issue in robozonky?

Marfusios commented 6 years ago

Thanks, yes it is the only change.

Sure, I wanted to change strategy after Robozonky was installed, so I just composed and downloaded a file from the website, but I had to change extension manually from txt to cfg, unfortunately, Windows also automatically changed encoding to 'ANSI'. And that caused the issue.

jhrcek commented 6 years ago

@Marfusios thanks for the explanation. The config tool is now using the same filename as expected by Robozonky, so no renaming should be necessary from now on.