RoboZonky / natural-strategy-setup

Webový konfigurátor investiční strategie pro RoboZonky
https://robozonky.github.io/konfigurace-strategie/
2 stars 1 forks source link

Prevent confusion around filter conditions being implicitly joined by AND and filters joined by OR #41

Closed jhrcek closed 6 years ago

jhrcek commented 6 years ago

People are often creating filters that are too restrictive (filter-out everything), because:

We should take some steps to prevent this confusion. Two ideas to prevent the above mentioned problems:

jhrcek commented 6 years ago

@triceo I implemented first improved prototype of conditions creation as described in the first comment ^ and shown in this screenshot:

screenshot from 2018-08-05 14-54-01

You can play with the modified version in my testing deployment. I realize I'm about half-way to the solution you envisioned, but let's discuss the current improvement in person before I invest more time in it :-)

PS.: I made a couple of other changes:

jhrcek commented 6 years ago

Feedback from in-person discussion with @triceo Let's leave this as for now and see if people still find this confusing. Just include these minor modifications:

  1. also make the "disjunction" that connects individual filters explicit - it would be separate div "joining" the individual filter divs in the preview.
  2. change the styling of the connectives: use bootstrap pill badges - secondary for "or" and info for "and".
  3. (unrelated) change "robot má udržovat prázdné portfolio." to mnou definované