search

RoboZonky / natural-strategy-setup

Webový konfigurátor investiční strategie pro RoboZonky
https://robozonky.github.io/konfigurace-strategie/
2 stars 1 forks source link

Simplify marketplace enablement configuration #43

Closed jhrcek closed 6 years ago

jhrcek commented 6 years ago

At the moment there is "2-level" configuration nested inside "Pravidla prodeje" and "Pravidla nákupu". First user chooses whether he wants to enable/disable marketplace and then has to specify filters.

It would be better to have primary/secondary marketplace enablement controls in the General settings. The Filter accordion sections would be shown only when enabled in general settings. Primary would be enabled by default, secondary disabled by default. When primary enabled we would infer "buy everything" from empty filter list.

jhrcek commented 6 years ago

It turns out that moving part of the configuration to General settings was not a good idea as it made the UI less intuitive and predictable. On the other hand it was still possible to simplify configuration UI in the "Pravidla nákupu" section (removing the 3 radios) without reducing existing functionality. @triceo please check the simplification in my testing deployment and let me know if you like it.

triceo commented 6 years ago

Looks good to me, thanks!