RoboZonky / natural-strategy-setup

Webový konfigurátor investiční strategie pro RoboZonky
https://robozonky.github.io/konfigurace-strategie/
2 stars 1 forks source link

Add support for participation sale without fees #58

Closed triceo closed 5 years ago

triceo commented 5 years ago

See https://github.com/RoboZonky/robozonky/issues/400 which adds a new sale filter.

triceo commented 5 years ago

(Will be available in RoboZonky 5.2.0.CR1, to be released today. The final most likely 2 weeks later.)

triceo commented 5 years ago

I described all the changes here: https://github.com/RoboZonky/robozonky/wiki/Co-nov%C3%A9ho-ve-verzi-5.2

jhrcek commented 5 years ago

Ok, I'll work on this in the next few days

jhrcek commented 5 years ago

@triceo I checked the changes. This will require changes in "Pravidla prodeje" section. Until now, there were 2 states represented implicitly:

  1. Prodej participací zakázán. (represented by no sell rules being added)
  2. Prodej participací povolen (represented by 1+ sell rules being added)

This change will require third state to be added

  1. Prodávat všechny participace bez poplatku, které odpovídají filtrům tržiště.

So now we'll have to represent the 3 choices explicitly, probably using 3 radio buttons. Are you ok with this layout (just a mockup so far) or do you have some other proposals?

Screenshot from 2019-05-02 06-37-27

This will also mean

triceo commented 5 years ago

Makes sense, it is consistent with what we're doing in other places of the tool.

Just one comment, since you didn't mention it - the buttons for adding rules should either be completely gone or at least greyed out when in the first two modes.

jhrcek commented 5 years ago

Sure, I'll make it so that the rule-adding buttons are only present when the third option is selected.