PR No 2

[Darudas]

I am a fan of the AmazingTrading mod and have been working on some enhancements to help it shine even more in the future. Here are the key improvements I've made:

Enhancements

• Missing Recipes: Added the missing recipes to ensure all items can be processed correctly.
• Shredder Enhancements:
  • Hopper-like Functionality: The shredder can now automatically suck items into its inventory, making it more efficient and user-friendly.
  • Item Display: Items being processed by the shredder are now visually displayed, providing better feedback to the player.
  • Universal Crushing: The shredder can now crush any item, even those without predefined values. Crushed items are stored and can be bought back for 1 unit. Additionally, there is a 50/50 chance to gain 1 unit by shredding these items down.

New Command

• /amt increment Command: Added a new command to increment the amount of a specific item in the player's shop inventory.

I believe these enhancements and fixes will significantly improve the user experience and functionality of the mod. I look forward to your feedback and hope these changes can be integrated into the main project.

[Darudas]

@Robocraft999

[Robocraft999]

So first of all I'm sorry that I let you wait and thanks for your work. But there are a few things I would change. The first thing is to maybe move the sucking of items to a seperate Block like a hopping shredder (extending the current). Furthermore there are some weird ways you try to get the resourcepoint values. The recipes are very nice though. The shredding of items without value I'm not sure about. I thought about maybe putting it beheind a config or something but it kind of breaks with the concept of only being to crush predefined items and not really being a trashcan. The command thing i would move to a seperate pr. I also will have to have a look at the displaying before merging. Also I have to get the fluid integration working I'm working on right now to release it alltogether as 0.2, but it's a bit broken right now.

[Robocraft999]

So i had a look now. The Item displaying looks very nice, the recipes are nice, but I don't understand why to add this command. Also the sucking seems only to work if the inventory is empty and single items sometimes don't get displayed.

[Darudas]

and I would love to talk to you in discord a bit about the mod to get a better understanding of what you want and what you dont want in the mod in the future and I would love to share you some of my workflows and would love to know what you think about it

[Robocraft999]

merge and remove or edit whatever you want and I will than work furter with your edits and sorry for all the leftovers as I am kinda new to git and still do most stuff the oldscool way with my limited knowladge and thats how some stuff gets removed or left from a side project with the code, I should start using branches xD

Don't worry that's the same for me. I'm still afraid of using branches for everything and so on, but I think eventually I'll get used to it. (Also first time using this review feature of github for this pr). Regarding the discord thing, sure. Just contact me.

[Darudas]

Ive send you a friend requests but because of your privacy settings I can't send you a massage