RobokopU24 / Feedback

Feedback on the ROBOKOP project
https://robokop.renci.org
0 stars 0 forks source link

Remove self-subclasses #194

Open hina-shah opened 9 months ago

hina-shah commented 9 months ago

To reproduce: In question builder, try submitting a query "asthma" relates to "asthma". This will create a result table, and one of the rows should be from asthma to asthma. If you click on the row it looks like here in the image:

image
cbizon commented 5 months ago

I think we should filter out A - subclass-of - A edges somewhere. Logically true; totally useless.

EvanDietzMorris commented 5 months ago

Is this something we could apply more generally? Are there any A-->A edges in robokop we care about? The issue is complicated by the fact that this can occur during normalization.

cbizon commented 5 months ago

I think that there are probably self-interaction or self-regulation edges that we would want to keep

EvanDietzMorris commented 5 months ago

cool, I think if we want zero A-subclass_of-A edges we can pretty easily apply that in normalization by default, but it should probably be it's own operation that can be specified in the graph spec