Conrad is not supposed to have luck

Robosturm / Commander_Wars

The aim of this project is to create an Advance Wars Clone with a lot of additions customizations and modding support. For Contact Inforamtion see the wiki page. Take a view on the game.

https://github.com/Robosturm/Commander_Wars/releases

GNU Lesser General Public License v3.0

217 stars 32 forks source link

Conrad is not supposed to have luck #1753

Closed MrDuck557 closed 9 months ago

MrDuck557 commented 9 months ago

Changed unit.getHpRounded() to just 10 luck damage already factors unit hp in

before change: Conrad has luck. This is bad.

after change: Conrad has no luck. This is good.

Robosturm commented 9 months ago

Won't be merged but gets fixed with a commit. To prevent multiple definitions of magic numbers, which lead to this bug.

Robosturm commented 9 months ago

The actual fix is no part of the repo where Conrad graps the default luck from the Action_Fire