search

Robosturm / Commander_Wars

The aim of this project is to create an Advance Wars Clone with a lot of additions customizations and modding support. For Contact Inforamtion see the wiki page. Take a view on the game.
https://github.com/Robosturm/Commander_Wars/releases
GNU Lesser General Public License v3.0
213 stars 33 forks source link

Max's COP and SCOP Increase the Movement of Incorrect Units #1772

Closed FruityGumGuiltyFruit closed 6 months ago

FruityGumGuiltyFruit commented 6 months ago

Describe the bug Read title. This seems unintended, probably happens because his stats are programmed to check max range, and not if the unit is able to attack.

To Reproduce Steps to reproduce the behavior:

  1. Use Max's COP or SCOP in battle.
  2. See error

Expected behavior COP/SCOP should not boost these units, or Max's stat text should be changed to make it seem intention. Max in official AW1 also has this issue, but not in AW2 or AW3. I believe the programmers of that game made a similar error.

Desktop (please complete the following information):

OS: [Windows 10 Home]
Version [22h2]
Active Mods (None)
Game Version [Beta v36]

max scop stats

MrDuck557 commented 6 months ago

I wonder if simply setting the max range to 0 would break anything

FruityGumGuiltyFruit commented 6 months ago

Maybe instead, Robosturm could add an additional check, to see if the unit has at least a weapon in the primary or secondary slot. Something like unit.getWeapon1ID() !== "" && unit.getWeapon2ID() !== "".