search

RobotCasserole1736 / RobotCasserole2017

Robot Casserole robot source code for the 2017 FRC game, First Steamworks.
MIT License
0 stars 0 forks source link

Fix mixed usage of spaces and tabs #93

Closed gerth2 closed 7 years ago

gerth2 commented 7 years ago

Audit all java source files for this year's code - find replace all instances of tab characters with four spaces.

I like spaces better than tabs. Others may dissent.

imdunne8 commented 7 years ago

I don't have any huge issue with spaces, but I personally prefer tabs and I think there are better logical arguments to be made for tabs over spaces, but there's no need to argue about that. Eclipse by default is set up to use tabs (such as when you open a class or method with a { and press enter, and also for the auto formatter), and that's likely what almost everybody has in their code already because of it. So unless we want to change everybody's Eclipse settings and then be sure they're changed again any time we reinstall (not that it's a difficult change though), it is probably best to stick with tabs.

As a side note, I was actually really surprised that in Java spaces are far more commonly used than tabs, but in C tabs beat out spaces by a small margin. I wasn't at all surprised to see that number of spaces is ridiculously unstandardized.

gerth2 commented 7 years ago

I'll rephrase my thoughts on this one - I would prefer to go with whatever eclipse does by default - if that's tabs, we can go for that...

gerth2 commented 7 years ago

done