RobotCing / Cing

Official github for robot Cing. Learn More at:
https://robotcing.github.io/RobotCing-Website/
GNU Lesser General Public License v3.0
3 stars 1 forks source link

Remove invalid reference link from keywords.txt #2

Closed per1234 closed 6 years ago

per1234 commented 6 years ago

The third field of keywords.txt is used to provide Arduino Language Reference links, which are accessed from the Arduino IDE by highlighting the keyword and then selecting "Find in Reference" from the Help or right click menu. Adding values to this field that do not match any existing reference pages results in a "Could not open the URL" error.

Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywordstxt-format

RobotCing commented 6 years ago

Thanks for letting us know. We will fix it in next generation.

Best Regards RobotCing Team

per1234 commented 6 years ago

@RobotCing why did you close this as "wontfix" after you said you were going to fix it?

RobotCing commented 6 years ago

Sorry we didint realise correctly what it means. It should be already fixed only arduino highlights arent fixed at the moment but we are working on that.

Best regards RobotCing Team

per1234 commented 6 years ago

You didn't fix it. You just changed from one invalid reference link (atmega) to a different invalid reference link (Cing).

For future reference, you might be interested to know that you can simply click the "Merge pull request" button on a pull request to accept the proposed changes to your repository. This is much easier and less prone to errors than trying to reproduce the changes yourself. For more information, see: https://help.github.com/articles/merging-a-pull-request/ Of course, you're welcome to manage your project as you see fit. What's important to me is that the problem is resolved, rather than how it's resolved.

RobotCing commented 6 years ago

Sorry we didn't understand what you wanted but now we do. Will fix it as soon as posible.

Best regards RobotCing Team

StanislavJochman commented 6 years ago

Fixed