cfg files use underscore instead of dash as required by setuptools

RobotLabLTH / skiros2

A skill-based platform for ROS v.2

Other

163 stars 20 forks source link

cfg files use underscore instead of dash as required by setuptools #50

Closed robberthofmanfm closed 2 years ago

robberthofmanfm commented 2 years ago

~/.local/lib/python3.8/site-packages/setuptools/dist.py:739: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead

https://setuptools.pypa.io/en/latest/history.html#v54-1-0

robberthofmanfm commented 2 years ago

Oh nevermind, this is a ROS2-wide problem https://github.com/ament/ament_cmake/issues/382

frvd commented 2 years ago

So, should this be merged or not? With ROS2 foxy I didn't get any warning

robberthofmanfm commented 2 years ago

I would not merge it. Apparently it occurs with newer versions of setuptools (I'm at v60.10.0, you've probably got an earlier one). In newer versions of ROS2 it should've been fixed already.