start the mTimer during initialization of ddLCMSubscriber

RobotLocomotion / director

A robotics interface and visualization framework, with extensive applications for working with http://drake.mit.edu

BSD 3-Clause "New" or "Revised" License

178 stars 86 forks source link

start the mTimer during initialization of ddLCMSubscriber #562

Closed manuelli closed 6 years ago

manuelli commented 6 years ago

Previously the mTimer wasn't being started. If you then called setSpeedLimit(60) then the notification would never get passed up to python due to the fact that mTimer.elapsed() was always equal to zero. So we would get stuck here.

I think this bug has been here all along. Probably what happened is that the default behavior changed when we upgraded the Qt version (or it's simply undefined and behaves strangely on 16.04). Anyways I think this PR fixes the issue.

@patmarion

patmarion commented 6 years ago

just tested in qt 4.8.7 and qtime object does start automatically, but the QTime documentation says you should have to call start(), so looks like this is a behavior change that was fixed in Qt5.