search

RobotLocomotion / director

A robotics interface and visualization framework, with extensive applications for working with http://drake.mit.edu
BSD 3-Clause "New" or "Revised" License
178 stars 86 forks source link

Various compatibility updates #597

Closed jamiesnape closed 6 years ago

jamiesnape commented 6 years ago

Relates https://github.com/RobotLocomotion/spartan/issues/266. PTAL @patmarion.

patmarion commented 6 years ago

Thanks @jamiesnape! Looks like this PR failed the ubuntu14 tests. While I would be happy to drop Ubuntu 14 at this point, I think it is easy to fix this failure by modifying externals.cmake. See this line:

https://github.com/RobotLocomotion/director/blob/master/distro/superbuild/cmake/externals.cmake#L154

We need a similar line here:

https://github.com/RobotLocomotion/director/blob/master/distro/superbuild/cmake/externals.cmake#L583

Basically what is happening, is for systems with cmake < v3.1, we download a new version of cmake and use it when configuring projects that use lcm.

patmarion commented 6 years ago

i made the required fix in master so this PR would pass on travis-ci ubuntu14. thanks!